Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON: replace \mbox with \text #537

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Conversation

samuelfangjw
Copy link
Contributor

@samuelfangjw samuelfangjw commented Jun 17, 2021

This small pr changes \mbox in LaTeX equations to \text. I am trying to replace MathJax with another library (see this PR for the cadet frontend (KaTeX) that is much faster, but does not support \mbox.

The output seems to be the same.
Before:
Screenshot 2021-06-17 at 10 42 31 PM

After:
Screenshot 2021-06-17 at 10 41 46 PM

Copy link
Member

@martin-henz martin-henz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's reasonable. let's try KaTeX then.

@martin-henz martin-henz merged commit 56cfa17 into source-academy:master Jun 17, 2021
@samuelfangjw samuelfangjw deleted the katex branch June 20, 2021 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants