Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discourse reference detection bug, users case-sensitive #1479

Open
Beanow opened this issue Dec 7, 2019 · 2 comments
Open

Discourse reference detection bug, users case-sensitive #1479

Beanow opened this issue Dec 7, 2019 · 2 comments
Labels
bug Something isn't working

Comments

@Beanow
Copy link
Contributor

Beanow commented Dec 7, 2019

Noticed this as I was working on some prototype reference detection for Initiatives.

In the current implementation an @Beanow mention on the forum creates the URL https://discourse.sourcecred.io/u/beanow. When parsing this URL the username looks like beanow, creating an edge towards the lowercased node address. Which will be a dangling edge as my actual user node is capitalized.

┆Issue is synchronized with this Asana task by Unito

@Beanow
Copy link
Contributor Author

Beanow commented Dec 7, 2019

As a workaround, I've tried including a lowercase alias in the identities settings.

{
  "username": "Beanow",
  "aliases": ["github/Beanow", "discourse/Beanow", "discourse/beanow"]
},

This fixes the mentions for me :]

Perhaps as part of the unified reference detection we can discuss some canonicalization methods.

@teamdandelion
Copy link
Contributor

Good catch @Beanow. And good find with the workaround.

Beanow added a commit that referenced this issue Jan 7, 2020
Gets the username of a user, if it exists.
Helpful for fixing capitalization issues such as #1479,
and verifying the user exists for reference detection.
Beanow added a commit that referenced this issue Jan 7, 2020
Gets the username of a user, if it exists.
Helpful for fixing capitalization issues such as #1479,
and verifying the user exists for reference detection.
Beanow added a commit that referenced this issue Jan 11, 2020
Discourse ReferenceDetector detector that relies on database lookups.

(Should be the main way to solve #1479, when UniRef is used by all plugins)
@Beanow Beanow added the bug Something isn't working label Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants