UniRef: implement DiscourseReferenceDetector #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Beanow
force-pushed
the
wip/uniref-discourse
branch
from
98e4232
to
b0db4ce
Compare
Beanow
changed the base branch from
wip/uniref-discourse-base
to
wip/discourse-queries
teamdandelion
approved these changes
Jan 11, 2020
Beanow
force-pushed
the
wip/uniref-discourse
branch
from
b0db4ce
to
234e70e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1528 and #1490.
Discourse ReferenceDetector detector that relies on database lookups.
(Should be the main way to solve #1479, when UniRef is used by all plugins)
Test plan:
yarn unit