Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cache version suffix in circleCI #3159

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Add Cache version suffix in circleCI #3159

merged 1 commit into from
Aug 24, 2021

Conversation

topocount
Copy link
Member

This allows us to manually flush the build cache when needed.

test plan: The merkle Grain Integration needs the build cache cleared to
begin running successfully and this should do it. Unfortunately this can
really only be tested in CI.

This allows us to manually flush the build cache when needed.

test plan: The merkle Grain Integration needs the build cache cleared to
begin running successfully and this should do it. Unfortunately this can
really only be tested in CI.
- v1-node<< parameters.node_version >>-dependencies-
# added a versioning suffix to allow for manual cache clearing:
# https://support.circleci.com/hc/en-us/articles/115015426888-Clear-project-dependency-cache
- v1-node<< parameters.node_version >>-dependencies-v0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't match the article linked, which uses an environment variable. Could you explain a little more how this is going to work?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on the fence about using an environment variable to flush the cache, because it seems like an unnecessarily high-permissioned, centralized locale. By keeping it in the file, we can track cache clearing in a single place as a part of a change set.

Additionally, if we use an environment variable, this affects all branches. I think managing cache flushes on a per-branch basis is preferable, personally.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OH I see, the other PR is pointing to this branch. Cool I get it now. Yeah that seems better.

@topocount topocount merged commit 14d7d07 into main Aug 24, 2021
@topocount topocount deleted the ci-cache branch August 24, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants