Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RawGithubReadInstance wrapper for improved UX #3250

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Conversation

blueridger
Copy link
Member

Description

Finding and composing a raw github repo url is confusing, and we get tech support questions about it regularly. This adds a more user-friendly factory for instances that use raw github fetching.

Test Plan

yarn build && yarn shell

$ i = sc.instance.readInstance.getRawGithubReadInstance("sourcecred","cred","gh-pages")
Vd {
  _storage: Mu {
    _base: 'https://raw.githubusercontent.com/sourcecred/cred/gh-pages/'
  },
  _zipStorage: Su {
    _baseStorage: Mu {
      _base: 'https://raw.githubusercontent.com/sourcecred/cred/gh-pages/'
    }
  }
}
$ i.readLedger().then(l => console.log(l))

@blueridger blueridger force-pushed the raw-github branch 2 times, most recently from 855d5bd to f597ad3 Compare November 1, 2021 20:22
@blueridger blueridger merged commit 2c91304 into main Nov 2, 2021
@blueridger blueridger deleted the raw-github branch November 2, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants