-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resolving vendor libs through composer #1
Conversation
slightly refactored application.php and Bootstrap and removed some require onces here and there removed hard-copies and installing the following with composer "zendframework/zendframework1":">=1.12", "Smarty3":"3.0.8", "symfony/dependency-injection":"2.0", "symfony/event-dispatcher":"2.0", "doctrine/orm":"2.1.*", "doctrine/mongodb-odm":"*"
apt-get install libzend-framework is obsolete
awesome travis-ci failed to build my pull request :) |
requirement naming was referring to non existing packagist package
mongo entities should live in separate branch? were merged into next accidentally? hopefully unit tests run now
What about removing that commented code in application.php and removing composer.phar from repo? |
yeah sure good point |
also removed commented code in application.php resolves #1 (comment)
It also might be a good idea to completly remove Zend_Loader_Autoloader from Bootstrap - will leave that for later though. |
Yep. Works fine for me but the zend version check during install reports 1.11.0dev which won't pass required 1.11.5. I will merge it and update composer.json/lock to zend 1.11.* ok? |
I tried setting the require to: "zendframework/zendframework1":"dev-release-1.11" |
updated lock file accordingly
Notice plugin
fixes based on petr/newscoop_test_api
Added missing variable to Debate plugin class
… - should be "Archiv" and not "Suchergebnisse" test fix sourcefabric#1
… - should be "Archiv" and not "Suchergebnisse" test fix sourcefabric#1
slightly refactored autoloading in application.php and Bootstrap.php
removed some require onces here and there
removed hard-copies and set up composer to satisfy
following dependencies:
see http://forum.sourcefabric.org/discussion/14328/newscoop-dependency-management-and-autoloading-with-composer
should keep a working state of the application (manually tested)
unit test were neither running before nor after my changes afaik.