Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolving vendor libs through composer #1

Merged
merged 6 commits into from
Jul 19, 2012
Merged

resolving vendor libs through composer #1

merged 6 commits into from
Jul 19, 2012

Conversation

lenada
Copy link
Contributor

@lenada lenada commented Jul 11, 2012

slightly refactored autoloading in application.php and Bootstrap.php
removed some require onces here and there
removed hard-copies and set up composer to satisfy
following dependencies:

    "zendframework/zendframework1":">=1.12",
    "Smarty3":"3.0.8",
    "symfony/dependency-injection":"2.0",
    "symfony/event-dispatcher":"2.0",
    "doctrine/orm":"2.1.*",
    "doctrine/mongodb-odm":"*"

see http://forum.sourcefabric.org/discussion/14328/newscoop-dependency-management-and-autoloading-with-composer

should keep a working state of the application (manually tested)
unit test were neither running before nor after my changes afaik.

Leander added 2 commits July 12, 2012 00:15
slightly refactored application.php and Bootstrap and removed some require onces here and there

removed hard-copies and installing the following with composer
        "zendframework/zendframework1":">=1.12",
        "Smarty3":"3.0.8",
        "symfony/dependency-injection":"2.0",
        "symfony/event-dispatcher":"2.0",
        "doctrine/orm":"2.1.*",
        "doctrine/mongodb-odm":"*"
apt-get install libzend-framework is obsolete
@lenada
Copy link
Contributor Author

lenada commented Jul 12, 2012

awesome travis-ci failed to build my pull request :)
I still have a composer package naming error (preventing fresh installs)
fix is on the way.

Leander added 2 commits July 12, 2012 21:21
requirement naming was referring to non existing packagist package
mongo entities should live in separate branch? were merged into next accidentally?
hopefully unit tests run now
@ghost ghost assigned hlmnrmr and petrjasek Jul 18, 2012
@petrjasek
Copy link
Contributor

What about removing that commented code in application.php and removing composer.phar from repo?

@lenada
Copy link
Contributor Author

lenada commented Jul 18, 2012

yeah sure good point

also removed commented code in application.php
resolves #1 (comment)
@lenada
Copy link
Contributor Author

lenada commented Jul 18, 2012

It also might be a good idea to completly remove Zend_Loader_Autoloader from Bootstrap - will leave that for later though.

@petrjasek
Copy link
Contributor

Yep. Works fine for me but the zend version check during install reports 1.11.0dev which won't pass required 1.11.5. I will merge it and update composer.json/lock to zend 1.11.* ok?

@lenada
Copy link
Contributor Author

lenada commented Jul 18, 2012

I tried setting the require to: "zendframework/zendframework1":"dev-release-1.11"
that should checkout http://framework.zend.com/svn/framework/standard/branches/release-1.11/
the constant in version comes out as 1.11.12

updated lock file accordingly
@omniton omniton merged commit 3282e7b into sourcefabric:next Jul 19, 2012
hlmnrmr pushed a commit to hlmnrmr/Newscoop that referenced this pull request Sep 10, 2012
omniton pushed a commit that referenced this pull request Oct 29, 2012
fixes based on petr/newscoop_test_api
terwey referenced this pull request in terwey/Newscoop Oct 24, 2013
Added missing variable to Debate plugin class
m038 pushed a commit to m038/Newscoop that referenced this pull request Dec 19, 2013
… - should be "Archiv" and not "Suchergebnisse"

test fix sourcefabric#1
m038 pushed a commit to m038/Newscoop that referenced this pull request Dec 19, 2013
… - should be "Archiv" and not "Suchergebnisse"

test fix sourcefabric#1
@piseydba piseydba mentioned this pull request Sep 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants