fix(chore): fixed sonar issue

fixed sonar issue GH-125
sourcefuse · Nov 21, 2023 · aecef18 · aecef18
1 parent d8f9254
commit aecef18
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 20 deletions.
diff --git a/...strategies/passport/passport-client-password/client-password-strategy-factory-provider.ts b/...strategies/passport/passport-client-password/client-password-strategy-factory-provider.ts
@@ -1,13 +1,13 @@
 // SONAR-IGNORE-ALL
-import { inject, Provider } from '@loopback/core';
-import { HttpErrors, Request } from '@loopback/rest';
+import {inject, Provider} from '@loopback/core';
+import {HttpErrors, Request} from '@loopback/rest';
 // eslint-disable-next-line @typescript-eslint/naming-convention
 import * as ClientPasswordStrategy from './client-password-strategy';
 
-import { AuthErrorKeys } from '../../../error-keys';
-import { IAuthClient } from '../../../types';
-import { Strategies } from '../../keys';
-import { VerifyFunction } from '../../types';
+import {AuthErrorKeys} from '../../../error-keys';
+import {IAuthClient} from '../../../types';
+import {Strategies} from '../../keys';
+import {VerifyFunction} from '../../types';
 
 export interface ClientPasswordStrategyFactory {
   (
@@ -22,7 +22,7 @@ export class ClientPasswordStrategyFactoryProvider
   constructor(
     @inject(Strategies.Passport.OAUTH2_CLIENT_PASSWORD_VERIFIER)
     private readonly verifier: VerifyFunction.OauthClientPasswordFn,
-  ) { }
+  ) {}
 
   value(): ClientPasswordStrategyFactory {
     return (options, verifier) =>
@@ -53,7 +53,8 @@ export class ClientPasswordStrategyFactoryProvider
           clientSecret: string | undefined,
           cb: (err: Error | null, client?: IAuthClient | null) => void,
           req: Request | undefined,
-        ) => {//NOSONAR
+        ) => {
+          //NOSONAR
           try {
             const client = await verifyFn(clientId, clientSecret, req);
             this.clientPasswordVerifierHelper(client, clientSecret);
@@ -71,7 +72,8 @@ export class ClientPasswordStrategyFactoryProvider
           clientId: string,
           clientSecret: string | undefined,
           cb: (err: Error | null, client?: IAuthClient | null) => void,
-        ) => {//NOSONAR
+        ) => {
+          //NOSONAR
           try {
             const client = await verifyFn(clientId, clientSecret);
             this.clientPasswordVerifierHelper(client, clientSecret);

diff --git a/...ies/passport/passport-client-password/secure-client-password-strategy-factory-provider.ts b/...ies/passport/passport-client-password/secure-client-password-strategy-factory-provider.ts
@@ -1,12 +1,13 @@
-import { inject, Provider } from '@loopback/core';
-import { HttpErrors, Request } from '@loopback/rest';
+/* eslint-disable @typescript-eslint/no-misused-promises */
+import {inject, Provider} from '@loopback/core';
+import {HttpErrors, Request} from '@loopback/rest';
 // eslint-disable-next-line @typescript-eslint/naming-convention
 import * as ClientPasswordStrategy from './client-password-strategy';
 
-import { AuthErrorKeys } from '../../../error-keys';
-import { ClientType, IAuthSecureClient } from '../../../types';
-import { Strategies } from '../../keys';
-import { VerifyFunction } from '../../types';
+import {AuthErrorKeys} from '../../../error-keys';
+import {ClientType, IAuthSecureClient} from '../../../types';
+import {Strategies} from '../../keys';
+import {VerifyFunction} from '../../types';
 
 export interface SecureClientPasswordStrategyFactory {
   (
@@ -21,7 +22,7 @@ export class SecureClientPasswordStrategyFactoryProvider
   constructor(
     @inject(Strategies.Passport.OAUTH2_CLIENT_PASSWORD_VERIFIER)
     private readonly verifier: VerifyFunction.OauthSecureClientPasswordFn,
-  ) { }
+  ) {}
 
   value(): SecureClientPasswordStrategyFactory {
     return (options, verifier) =>
@@ -42,15 +43,15 @@ export class SecureClientPasswordStrategyFactoryProvider
       // do nothing
     }
   }
-
+  //prettier-ignore-start
+  // prettier-ignore
   getSecureClientPasswordVerifier(
     options?: ClientPasswordStrategy.StrategyOptionsWithRequestInterface,
     verifierPassed?: VerifyFunction.OauthSecureClientPasswordFn,
   ): ClientPasswordStrategy.Strategy {
     const verifyFn = verifierPassed ?? this.verifier;
     if (options?.passReqToCallback) {
       return new ClientPasswordStrategy.Strategy(
-        // eslint-disable-next-line @typescript-eslint/no-misused-promises
         async (
           clientId: string,
           clientSecret: string | undefined,
@@ -70,12 +71,10 @@ export class SecureClientPasswordStrategyFactoryProvider
       );
     } else {
       return new ClientPasswordStrategy.Strategy(
-        // eslint-disable-next-line @typescript-eslint/no-misused-promises
         async (
           clientId: string,
           clientSecret: string | undefined,
           cb: (err: Error | null, client?: IAuthSecureClient | null) => void,
-          // eslint-disable-next-line @typescript-eslint/no-explicit-any
         ) => {// NOSONAR
           try {
             const client = await verifyFn(clientId, clientSecret);
@@ -90,4 +89,5 @@ export class SecureClientPasswordStrategyFactoryProvider
       );
     }
   }
+  //prettier-ignore-end
 }