Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All passport packages should be optional, and the user should install them only if required. #125

Closed
akshatdubeysf opened this issue Jan 14, 2023 · 1 comment · Fixed by #156
Closed

All passport packages should be optional, and the user should install them only if required. #125

akshatdubeysf opened this issue Jan 14, 2023 · 1 comment · Fixed by #156
Assignees
@karuneshsf
Labels
released

Comments

@akshatdubeysf
Copy link
Contributor

Describe the bug
Currently all the passport packages are installed for all the users, this should not happen ideally.

To Reproduce
Steps to reproduce the behavior:

  1. install loopback4-authentication
  2. Check the node-modules, it has all the passport strategies

Expected behavior
Only the packages required by the user should be installed
RaghavaroraSF added a commit that referenced this issue Mar 20, 2023
@RaghavaroraSF
fix(component): make passport packages optional
d5069cb 
All passport packages are made optional, and the user should install them only if required.

BREAKING CHANGE:
change import path for specific passport packages

GH-125
@RaghavaroraSF RaghavaroraSF mentioned this issue Mar 20, 2023
Closed
12 tasks
RaghavaroraSF added a commit that referenced this issue Mar 20, 2023
@RaghavaroraSF
Merge branch 'master' into GH-125
9490394
RaghavaroraSF added a commit that referenced this issue Mar 22, 2023
@RaghavaroraSF
fix(component): make passport packages optional
df582fb 
All passport packages are made optional, and the user should install them only if required.

BREAKING CHANGE:
change import path for specific passport packages

GH-125
RaghavaroraSF added a commit that referenced this issue Apr 19, 2023
@RaghavaroraSF
fix(component): make passport packages optional
5fc916f 
All passport packages are made optional, and the user should install them only if required.

BREAKING CHANGE:
change import path for specific passport packages

GH-125
RaghavaroraSF added a commit that referenced this issue Apr 19, 2023
@RaghavaroraSF
fix(component): make passport packages optional
2d9998a 
All passport packages are made optional, and the user should install them only if required.

GH-125
RaghavaroraSF added a commit that referenced this issue Apr 19, 2023
@RaghavaroraSF
fix(component): make passport packages optional
325825a 
All passport packages are made optional, and the user should install them only if required.

BREAKING CHANGE:
change import path for specific passport packages

GH-125
@RaghavaroraSF RaghavaroraSF mentioned this issue Apr 19, 2023
Merged
10 tasks
RaghavaroraSF added a commit that referenced this issue May 11, 2023
@RaghavaroraSF
fix(component): make passport packages optional
9e56ecd 
All passport packages are made optional, and the user should install them only if required.

BREAKING CHANGE:
change import path for specific passport strategies

GH-125
RaghavaroraSF added a commit that referenced this issue May 11, 2023
@RaghavaroraSF
Merge branch 'master' into GH-125
913ff76
@shubhamp-sf shubhamp-sf removed their assignment Jun 19, 2023
@stale stale bot added the stale label Jul 3, 2023
@shubhamp-sf shubhamp-sf removed the stale label Jul 4, 2023
@sourcefuse sourcefuse deleted a comment from stale bot Jul 4, 2023
karuneshsf pushed a commit that referenced this issue Nov 9, 2023
fix(component): allpassport packages made optional
8202802 
All passport packages are made optional, and the user should install them only if required.

BREAKING CHANGE:
changes for seprating passport packages

GH-125
karuneshsf pushed a commit that referenced this issue Nov 9, 2023
@RaghavaroraSF
fix(component): make passport packages optional
613cff4 
All passport packages are made optional, and the user should install them only if required.
BREAKING
CHANGE:
change import path for specific passport strategies
GH-125

BREAKING CHANGE:
rebased with master
karuneshsf pushed a commit that referenced this issue Nov 9, 2023
fix(component): allpassport packages made optional
96ab8ca 
All passport packages are made optional, and the user should install them only if required.
BREAKING
CHANGE:
changes for seprating passport packages
GH-125
karuneshsf pushed a commit that referenced this issue Nov 9, 2023
fix(component): added description in readme
7e47b54 
added description in readme

GH-125
karuneshsf pushed a commit that referenced this issue Nov 9, 2023
fix(component): added description in readme
317f6de 
added description in readme
GH-125
karuneshsf pushed a commit that referenced this issue Nov 20, 2023
fix(chore): sonar issue fix
704445f 
fix for Unexpected lexical declaration in case block

GH-125
karuneshsf pushed a commit that referenced this issue Nov 20, 2023
fix(chore): fixed sonar issue
dc84c0f 
fixed sonar issue Refactor this function to reduce its Cognitive Complexity

GH-125
karuneshsf pushed a commit that referenced this issue Nov 20, 2023
fix(chore): fixed sonar issue
bd39970 
fixed sonar issue replace this union type with a type alias.

GH-125
karuneshsf pushed a commit that referenced this issue Nov 20, 2023
fix(chore): fixed sonar issue
6c37c31 
fixed sonar issue replace this union type with a type alias.
GH-125
karuneshsf pushed a commit that referenced this issue Nov 20, 2023
fix(chore): fixed sonar issue
ef88d2d 
disabled sonar issue for Promise returned in function argument where a void return was expected

GH-125
karuneshsf pushed a commit that referenced this issue Nov 20, 2023
fix(chore): fixed sonar issue
ef7432a 
disabled sonar issue for Promise returned in function argument where a void return was
expected
GH-125
karuneshsf pushed a commit that referenced this issue Nov 20, 2023
fix(chore): sonar fixes
e168fde 
sonar fixes

GH-125
karuneshsf pushed a commit that referenced this issue Nov 21, 2023
fix(chore): fixed sonar issues
d8f9254 
fixed sonar issues

GH-125
karuneshsf pushed a commit that referenced this issue Nov 21, 2023
fix(chore): fixed sonar issue
aecef18 
fixed sonar issue

GH-125
karuneshsf pushed a commit that referenced this issue Nov 21, 2023
fix(chore): fixed sonar issue
7a6dd07 
fixed sonar issue

GH-125
karuneshsf pushed a commit that referenced this issue Nov 21, 2023
fix(chore): code review comment fix
35883af 
code review comment fix

GH-125
yeshamavani pushed a commit that referenced this issue Nov 21, 2023
@RaghavaroraSF
fix(component): make passport packages optional (#156)
99e0b2f 
* fix(component): make passport packages optional

All passport packages are made optional, and the user should install them only if required.
BREAKING
CHANGE:
change import path for specific passport strategies
GH-125

BREAKING CHANGE:
rebased with master

* fix(component): allpassport packages made optional

All passport packages are made optional, and the user should install them only if required.
BREAKING
CHANGE:
changes for seprating passport packages
GH-125

* fix(component): added description in readme

added description in readme
GH-125

* fix(chore): sonar issue fix

fix for Unexpected lexical declaration in case block

GH-125

* fix(chore): fixed sonar issue

fixed sonar issue Refactor this function to reduce its Cognitive Complexity

GH-125

* fix(chore): fixed sonar issue

fixed sonar issue replace this union type with a type alias.
GH-125

* fix(chore): fixed sonar issue

disabled sonar issue for Promise returned in function argument where a void return was
expected
GH-125

* fix(chore): sonar fixes

sonar fixes

GH-125

* fix(chore): fixed sonar issues

fixed sonar issues

GH-125

* fix(chore): fixed sonar issue

fixed sonar issue

GH-125

* fix(chore): fixed sonar issue

fixed sonar issue

GH-125

* fix(chore): code review comment fix

code review comment fix

GH-125

---------

Co-authored-by: Karunesh Mani Tripathi <karunesh@sourcefuse.com>
@yeshamavani
Copy link
Contributor

🎉 This issue has been resolved in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karuneshsf karuneshsf

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(component): make passport packages optional sourcefuse/loopback4-authentication
6 participants
@karuneshsf @akshatdubeysf @yeshamavani @RaghavaroraSF @Surbhi-sharma1 @shubhamp-sf