Skip to content

Commit

Permalink
fix(core): remove en.json changes (#29)
Browse files Browse the repository at this point in the history
SFO-92
  • Loading branch information
vineet-suri authored Jun 23, 2020
1 parent 3a577f5 commit 09c513e
Show file tree
Hide file tree
Showing 11 changed files with 42 additions and 21 deletions.
4 changes: 2 additions & 2 deletions packages/core/locales/en.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"NotAllowedAccess": "NotAllowedAccess"
}
"NotAllowedAccess": "NotAllowedAccess"
}
4 changes: 3 additions & 1 deletion sandbox/testing/src/controllers/ping.controller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,9 @@ const PING_RESPONSE: ResponseObject = {
* A simple controller to bounce back http requests
*/
export class PingController {
constructor(@inject(RestBindings.Http.REQUEST) private readonly req: Request) {}
constructor(
@inject(RestBindings.Http.REQUEST) private readonly req: Request,
) {}

// Map to `GET /ping`
@authorize(['*'])
Expand Down
4 changes: 3 additions & 1 deletion services/scheduler-service/.prettierignore
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
dist
*.json
migrations/
migrations/
coverage/
.nyc_output
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import {
Subscription,
} from '../../models';
import {Filter} from '@loopback/repository';
import { IdentifierType } from '../../models/enums/identifier-type.enum';
import {IdentifierType} from '../../models/enums/identifier-type.enum';

describe('Validator Service', () => {
let calendarRepo: StubbedInstanceWithSinonAccessor<CalendarRepository>;
Expand Down Expand Up @@ -102,7 +102,10 @@ describe('Validator Service', () => {
});
const filter: Filter = {
where: {
and: [{identifier: currentUser[IdentifierType.Id]}, {isPrimary: true}],
and: [
{identifier: currentUser[IdentifierType.Id]},
{isPrimary: true},
],
},
};
const findOne = subscriptionRepo.stubs.findOne;
Expand All @@ -117,7 +120,10 @@ describe('Validator Service', () => {
const id = 'primary';
const filter: Filter = {
where: {
and: [{identifier: currentUser[IdentifierType.Id]}, {isPrimary: true}],
and: [
{identifier: currentUser[IdentifierType.Id]},
{isPrimary: true},
],
},
};
const findOne = subscriptionRepo.stubs.findOne;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ import {AccessRoleType} from '../models/enums/access-role.enum';
import {PermissionKey} from '../models/enums/permission-key.enum';
import {SubscriptionRepository} from '../repositories';
import {ValidatorService} from '../services/validator.service';
import { ISchedulerConfig } from '../types';
import { SchedulerBindings } from '../keys';
import { IdentifierType } from '../models/enums/identifier-type.enum';
import {ISchedulerConfig} from '../types';
import {SchedulerBindings} from '../keys';
import {IdentifierType} from '../models/enums/identifier-type.enum';

const basePath = '/subscriptions';

Expand All @@ -49,7 +49,7 @@ export class SubscriptionController {
@inject(SchedulerBindings.Config, {
optional: true,
})
private readonly schdulerConfig?: ISchedulerConfig
private readonly schdulerConfig?: ISchedulerConfig,
) {}

@authenticate(STRATEGY.BEARER, {
Expand Down Expand Up @@ -124,7 +124,7 @@ export class SubscriptionController {
@param.query.string('minAccessRole') minAccessRole?: AccessRoleType,
): Promise<Subscription[]> {
let identifierType = this.schdulerConfig?.identifierMappedTo;
if (!identifierType){
if (!identifierType) {
identifierType = IdentifierType.Id;
}
return this.subscriptionRepository.find({
Expand Down
2 changes: 1 addition & 1 deletion services/scheduler-service/src/models/attendee.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export class Attendee extends UserModifiableEntity
@property({
type: 'string',
required: true,
name:'identifier',
name: 'identifier',
jsonSchema: {
maxLength: 200,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ export const enum IdentifierType {
Email = 'email',
Id = 'id',
TenantId = 'tenantId',
UserTenantId = 'userTenantId'
UserTenantId = 'userTenantId',
}
8 changes: 8 additions & 0 deletions services/scheduler-service/src/models/enums/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
export * from './access-role.enum';
export * from './day-of-week.enum';
export * from './error-keys';
export * from './identifier-type.enum';
export * from './owner-type.enum';
export * from './permission-key.enum';
export * from './response-status.enum';
export * from './status.enum';
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ export class Subscription extends UserModifiableEntity
@property({
type: 'string',
required: true,
name:'identifier'
name: 'identifier',
})
identifier: string;

Expand Down
13 changes: 8 additions & 5 deletions services/scheduler-service/src/services/validator.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ import {
EventRepository,
SubscriptionRepository,
} from '../repositories';
import { ISchedulerConfig } from '../types';
import { SchedulerBindings } from '../keys';
import { IdentifierType } from '../models/enums/identifier-type.enum';
import {ISchedulerConfig} from '../types';
import {SchedulerBindings} from '../keys';
import {IdentifierType} from '../models/enums/identifier-type.enum';

@bind({scope: BindingScope.TRANSIENT})
export class ValidatorService {
Expand Down Expand Up @@ -67,12 +67,15 @@ export class ValidatorService {
async primaryToCalendarId(id: string) {
if (id === 'primary') {
let identifierType = this.schdulerConfig?.identifierMappedTo;
if (!identifierType){
if (!identifierType) {
identifierType = IdentifierType.Id;
}
const subcription = await this.subscriptionRepository.findOne({
where: {
and: [{identifier: this.currentUser[identifierType]}, {isPrimary: true}],
and: [
{identifier: this.currentUser[identifierType]},
{isPrimary: true},
],
},
});
if (subcription) {
Expand Down
2 changes: 1 addition & 1 deletion services/scheduler-service/src/types.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import {IAuthUserWithPermissions} from '@sourceloop/core';
import { IdentifierType } from './models/enums/identifier-type.enum';
import {IdentifierType} from './models/enums/identifier-type.enum';

export interface CustomPermissionFn {
(user: IAuthUserWithPermissions): Promise<boolean>;
Expand Down

0 comments on commit 09c513e

Please sign in to comment.