Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sonar is RED #251

Closed
samarpan-b opened this issue Jul 12, 2021 · 0 comments · Fixed by #266
Closed

Sonar is RED #251

samarpan-b opened this issue Jul 12, 2021 · 0 comments · Fixed by #266
Assignees
@akshatdubeysf

Comments

@samarpan-b
Copy link
Contributor

Describe the bug
Sonar issues

https://sonarcloud.io/project/issues?id=sourcefuse_loopback4-microservice-catalog&resolved=false

Expected behavior
Sonar needs to be green
akshatdubeysf added a commit that referenced this issue Jul 19, 2021
@akshatdubeysf
refactor(authentication-service): fix sonar issues
acf0401 
BREAKING CHANGE:
changed client_id and client_secret to clientId and clientSecret in login-request dto and client-auth-req dto

GH-251
@akshatdubeysf akshatdubeysf mentioned this issue Jul 19, 2021
Merged
10 tasks
akshatdubeysf added a commit that referenced this issue Jul 19, 2021
@akshatdubeysf
refactor(authentication-service): fix sonar issues
257ca67 
BREAKING CHANGE:
changed client_id and client_secret to clientId and clientSecret in login-request dto and client-auth-req dto

GH-251
akshatdubeysf added a commit that referenced this issue Jul 21, 2021
@akshatdubeysf
fix(authentication-service): undo change to client id and secret
03b98c4 
GH-251
akshatdubeysf added a commit that referenced this issue Jul 21, 2021
@akshatdubeysf
fix(core): fix lint issue
1c29ee9 
GH-251
akshatdubeysf added a commit that referenced this issue Jul 21, 2021
@akshatdubeysf
refactor(authentication-service): fix sonar issues
def00fb 
BREAKING CHANGE:
changed client_id and client_secret to clientId and clientSecret in login-request dto and client-auth-req dto

GH-251
akshatdubeysf added a commit that referenced this issue Jul 21, 2021
@akshatdubeysf
fix(authentication-service): undo change to client id and secret
2c35a06 
GH-251
akshatdubeysf added a commit that referenced this issue Jul 21, 2021
@akshatdubeysf
fix(core): fix lint issue
1d3a7c3 
GH-251
akshatdubeysf added a commit that referenced this issue Jul 22, 2021
@akshatdubeysf
refactor(authentication-service): fix sonar issues
409e1a8 
BREAKING CHANGE:
changed client_id and client_secret to clientId and clientSecret in login-request dto and client-auth-req dto

GH-251
akshatdubeysf added a commit that referenced this issue Jul 22, 2021
@akshatdubeysf
fix(authentication-service): undo change to client id and secret
9e6a2a4 
GH-251
akshatdubeysf added a commit that referenced this issue Jul 22, 2021
@akshatdubeysf
fix(core): fix lint issue
c6e2b36 
GH-251
samarpan-b added a commit that referenced this issue Jul 22, 2021
@samarpan-b
Merge branch 'master' into GH-251
860ab51
samarpan-b pushed a commit that referenced this issue Jul 22, 2021
@akshatdubeysf
refactor(authentication-service): fix sonar issues (#266)
3ea2082 
GH-251
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@akshatdubeysf akshatdubeysf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(authentication-service): fix sonar issues sourcefuse/loopback4-microservice-catalog
2 participants
@samarpan-b @akshatdubeysf