Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bpmn-service): changed basePath #383

Merged
merged 2 commits into from
Oct 20, 2021
Merged

fix(bpmn-service): changed basePath #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd34424
fix(bpmn-service): changed basePath
AnkurBansalSF Oct 18, 2021
e6a2db0
Merge branch 'master' into gh-382
samarpan-b Oct 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions services/bpmn-service/openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
}
},
"paths": {
"/workflow/{id}/execute": {
"/workflows/{id}/execute": {
"post": {
"x-controller-name": "WorkflowController",
"x-operation-name": "startWorkflow",
Expand Down Expand Up @@ -49,7 +49,7 @@
"operationId": "WorkflowController.startWorkflow"
}
},
"/workflow/{id}/version/{version}": {
"/workflows/{id}/version/{version}": {
"delete": {
"x-controller-name": "WorkflowController",
"x-operation-name": "deleteVersionById",
Expand Down Expand Up @@ -87,7 +87,7 @@
"operationId": "WorkflowController.deleteVersionById"
}
},
"/workflow/{id}": {
"/workflows/{id}": {
"patch": {
"x-controller-name": "WorkflowController",
"x-operation-name": "updateById",
Expand Down Expand Up @@ -182,7 +182,7 @@
"operationId": "WorkflowController.deleteById"
}
},
"/workflow": {
"/workflows": {
"post": {
"x-controller-name": "WorkflowController",
"x-operation-name": "create",
Expand Down
42 changes: 21 additions & 21 deletions services/bpmn-service/openapi.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}/execute',
fetch('/workflows/{id}/execute',
{
method: 'POST',
body: inputBody,
Expand All @@ -73,7 +73,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}/execute',
fetch('/workflows/{id}/execute',
{
method: 'POST',
body: JSON.stringify(inputBody),
Expand All @@ -87,7 +87,7 @@ fetch('/workflow/{id}/execute',

```

`POST /workflow/{id}/execute`
`POST /workflows/{id}/execute`

> Body parameter

Expand Down Expand Up @@ -128,7 +128,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}/version/{version}',
fetch('/workflows/{id}/version/{version}',
{
method: 'DELETE',

Expand All @@ -149,7 +149,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}/version/{version}',
fetch('/workflows/{id}/version/{version}',
{
method: 'DELETE',

Expand All @@ -163,7 +163,7 @@ fetch('/workflow/{id}/version/{version}',

```

`DELETE /workflow/{id}/version/{version}`
`DELETE /workflows/{id}/version/{version}`

<h3 id="workflowcontroller.deleteversionbyid-parameters">Parameters</h3>

Expand Down Expand Up @@ -201,7 +201,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}',
fetch('/workflows/{id}',
{
method: 'PATCH',
body: inputBody,
Expand All @@ -228,7 +228,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}',
fetch('/workflows/{id}',
{
method: 'PATCH',
body: JSON.stringify(inputBody),
Expand All @@ -242,7 +242,7 @@ fetch('/workflow/{id}',

```

`PATCH /workflow/{id}`
`PATCH /workflows/{id}`

> Body parameter

Expand Down Expand Up @@ -285,7 +285,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}',
fetch('/workflows/{id}',
{
method: 'GET',

Expand All @@ -306,7 +306,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}',
fetch('/workflows/{id}',
{
method: 'GET',

Expand All @@ -320,7 +320,7 @@ fetch('/workflow/{id}',

```

`GET /workflow/{id}`
`GET /workflows/{id}`

<h3 id="workflowcontroller.count-parameters">Parameters</h3>

Expand Down Expand Up @@ -351,7 +351,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}',
fetch('/workflows/{id}',
{
method: 'DELETE',

Expand All @@ -372,7 +372,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow/{id}',
fetch('/workflows/{id}',
{
method: 'DELETE',

Expand All @@ -386,7 +386,7 @@ fetch('/workflow/{id}',

```

`DELETE /workflow/{id}`
`DELETE /workflows/{id}`

<h3 id="workflowcontroller.deletebyid-parameters">Parameters</h3>

Expand Down Expand Up @@ -424,7 +424,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow',
fetch('/workflows',
{
method: 'POST',
body: inputBody,
Expand Down Expand Up @@ -452,7 +452,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow',
fetch('/workflows',
{
method: 'POST',
body: JSON.stringify(inputBody),
Expand All @@ -466,7 +466,7 @@ fetch('/workflow',

```

`POST /workflow`
`POST /workflows`

> Body parameter

Expand Down Expand Up @@ -532,7 +532,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow',
fetch('/workflows',
{
method: 'GET',

Expand All @@ -554,7 +554,7 @@ const headers = {
'Authorization':'Bearer {access-token}'
};

fetch('/workflow',
fetch('/workflows',
{
method: 'GET',

Expand All @@ -568,7 +568,7 @@ fetch('/workflow',

```

`GET /workflow`
`GET /workflows`

<h3 id="workflowcontroller.find-parameters">Parameters</h3>

Expand Down
2 changes: 1 addition & 1 deletion services/bpmn-service/src/__tests__/acceptance/workflow.controller.acceptance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('Workflow Controller', () => {
let mockBpmnEngine: MockEngine;
let workflowRepo: WorkflowRepository;
let workflowVersionRepo: WorkflowVersionRepository;
const basePath = '/workflow';
const basePath = '/workflows';
const pass = 'test_password';
const testUser = {
id: 1,
Expand Down
2 changes: 1 addition & 1 deletion services/bpmn-service/src/controllers/workflow.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import {
WorkerImplementationFn,
WorkerMap,
} from '../types';
const basePath = '/workflow';
const basePath = '/workflows';

export class WorkflowController {
constructor(
Expand Down