Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update soft crud repository changes in mixin #129

Closed
shubhamp-sf opened this issue Feb 22, 2023 · 2 comments
Closed

Update soft crud repository changes in mixin #129

shubhamp-sf opened this issue Feb 22, 2023 · 2 comments
Assignees

Comments

@shubhamp-sf
Copy link
Contributor

Recent changes in the PR #122 are missing it's reflection in the soft-crud.repository.mixin.ts

@shubhamp-sf shubhamp-sf self-assigned this Feb 22, 2023
@shubhamp-sf
Copy link
Contributor Author

Same for the changes in #48, these are missing in mixing as well as default-transaction-soft-crud.repository

shubhamp-sf added a commit that referenced this issue Feb 22, 2023
add development note to ensure future modifications universal
add changes made in PR #122 in
soft-crud mixin and transaction-soft-crud repository

GH-129
shubhamp-sf added a commit that referenced this issue Feb 22, 2023
add development note to ensure future modifications universal
add changes made in PR #122 in
soft-crud mixin and transaction-soft-crud repository

GH-129
@shubhamp-sf
Copy link
Contributor Author

Closing this issue, as (upcoming PR containing) changes for removing duplicate code in mixin, base repo etc. will handle this by default.

yeshamavani pushed a commit that referenced this issue Feb 27, 2023
…ionSoftCrudRepository` (#131)

* fix(chore): add #122 changes in mixin and transaction repository

add development note to ensure future modifications universal
add changes made in PR #122 in
soft-crud mixin and transaction-soft-crud repository

GH-129

* refactor(chore): add common service and decorator for filter modification

created soft crud service file containing common code among artifacts
 created softFilter and
excludeSoftDeleted decorator for the common tasks

GH-128

* refactor(repository): deprecate `DefaultTransactionSoftCrudRepository`

in favor of SoftCrudRepositoryMixin for improving maintainability

GH-132

* refactor(repository): replace modify functions with custom soft filter builder

removed soft-crud service and used custom soft filter builder class providing methods like
imposeCondition, fields etc.

GH-0

* refactor(chore): resolve sonar code smells

ignore transactional respotory file in sonar as this is deprecated and kept duplicacy of the code
just for few months of support
 add avoid rule for arrowParens in prettier

GH-0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant