Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repository): added checks for fields passed as an array in case of findById #122

Merged
merged 1 commit into from Feb 14, 2023

Conversation

prernagp
Copy link
Contributor

@prernagp prernagp commented Feb 9, 2023

Description

  1. Added checks for fields passed as an array in function findById.
  2. Added test cases that validates output in case the fields are passed as an array

Fixes # (issue) GH-117

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested ?

  • findById should not return deleted record in case fields are passed as array
  • findById should not return deleted property in the model, if deleted is not passed as fields passed in array
  • findById should return deleted property in the model, if deleted is passed as fields passed in array

Checklist:

  • Performed a self-review of my own code
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide

…f findbyid

added checks for fields passed as an array in function findById.

sourcefuseGH-117
@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yeshamavani yeshamavani requested review from amandeep00001 and DeepakSF25 and removed request for amandeep00001 February 13, 2023 13:16
@yeshamavani yeshamavani merged commit 2a66e59 into sourcefuse:master Feb 14, 2023
@sfdevops
Copy link
Contributor

🎉 This PR is included in version 7.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

shubhamp-sf added a commit that referenced this pull request Feb 22, 2023
add development note to ensure future modifications universal
add changes made in PR #122 in
soft-crud mixin and transaction-soft-crud repository

GH-129
shubhamp-sf added a commit that referenced this pull request Feb 22, 2023
add development note to ensure future modifications universal
add changes made in PR #122 in
soft-crud mixin and transaction-soft-crud repository

GH-129
yeshamavani pushed a commit that referenced this pull request Feb 27, 2023
…ionSoftCrudRepository` (#131)

* fix(chore): add #122 changes in mixin and transaction repository

add development note to ensure future modifications universal
add changes made in PR #122 in
soft-crud mixin and transaction-soft-crud repository

GH-129

* refactor(chore): add common service and decorator for filter modification

created soft crud service file containing common code among artifacts
 created softFilter and
excludeSoftDeleted decorator for the common tasks

GH-128

* refactor(repository): deprecate `DefaultTransactionSoftCrudRepository`

in favor of SoftCrudRepositoryMixin for improving maintainability

GH-132

* refactor(repository): replace modify functions with custom soft filter builder

removed soft-crud service and used custom soft filter builder class providing methods like
imposeCondition, fields etc.

GH-0

* refactor(chore): resolve sonar code smells

ignore transactional respotory file in sonar as this is deprecated and kept duplicacy of the code
just for few months of support
 add avoid rule for arrowParens in prettier

GH-0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants