New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Working with design files + heading update #1187
Merged
AlicjaSuska
merged 8 commits into
master
from
Add-Working-with-design-files,-update-Design-Process-headers
Jul 22, 2020
Merged
Add Working with design files + heading update #1187
AlicjaSuska
merged 8 commits into
master
from
Add-Working-with-design-files,-update-Design-Process-headers
Jul 22, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added 'Working with design files' section that describes all the rules that we've agreed on recently when it comes to working with Figma files, naming conventions and Project Tools. In addition, I've changed slightly the formatting of the 'Process segments' section - using bold text for the main steps in the process increases the readability of this document. Please, share your feedback regarding both the content and the form :) Thank you!
christinaforney
approved these changes
Jul 13, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this! Just a few formatting notes.
rrhyne
reviewed
Jul 13, 2020
Co-authored-by: Christina Forney <christina@sourcegraph.com>
Co-authored-by: Christina Forney <christina@sourcegraph.com>
Co-authored-by: Christina Forney <christina@sourcegraph.com>
Co-authored-by: Christina Forney <christina@sourcegraph.com>
Co-authored-by: Christina Forney <christina@sourcegraph.com>
Changes according to Rob's suggestion. @rrhyne please review. Thank you!
rrhyne
approved these changes
Jul 17, 2020
…gn-Process-headers
AlicjaSuska
deleted the
Add-Working-with-design-files,-update-Design-Process-headers
branch
July 22, 2020 10:15
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added 'Working with design files' section that describes all the rules that we've agreed on recently when it comes to working with Figma files, naming conventions and Project Tools.
In addition, I've changed slightly the formatting of the 'Process segments' section - using bold text for the main steps in the process increases the readability of this document.
Please, share your feedback regarding both the content and the form :) Thank you!