Document Security Infrastructure #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElizabethStirling
requested review from
chayim,
pecigonzalo and
andreeleuterio
|
Notifying subscribers in CODENOTIFY files for diff 29bc542...b798907.
|
unknwon
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Thanks for writing these docs!
Would also love a review pass by @quinnkeast 😁
Co-authored-by: ᴜɴᴋɴᴡᴏɴ <joe@sourcegraph.com>
chayim
approved these changes
Jan 26, 2021
andreeleuterio
approved these changes
Jan 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brainstate dump of the infrastructure and logging work I've been doing recently. I definitely should have been doing this incrementally.
Please review this through the lens of "What question have I had for Elizabeth that this doesn't answer?"