Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ceros test embedded scripts #5282

Closed
wants to merge 8 commits into from
Closed

Ceros test embedded scripts #5282

wants to merge 8 commits into from

Conversation

st0nebreaker
Copy link
Contributor

@st0nebreaker st0nebreaker commented Apr 21, 2022

Closes #5272 by embedding some ceros scripts for branch environment troubleshooting.

Note

DON'T MERGE, this is a test for our Ceros trial

Test

  • Go to /ceros-microcontent to test the render of ceros microcontent script
  • Go to /ceros-full-page-takeover to test the render of ceros fullpage takeover script

@st0nebreaker st0nebreaker added team/content-platform marketing-request Used by CPT to indicate requests from the Marketing Team labels Apr 21, 2022
@st0nebreaker st0nebreaker added this to the A - Sprint 2 milestone Apr 21, 2022
@st0nebreaker st0nebreaker self-assigned this Apr 21, 2022
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Apr 21, 2022

Notifying subscribers in CODENOTIFY files for diff 46f7c1a...b1ae47e.

Notify File(s)
@sourcegraph/marketing website/src/html.tsx
website/src/pages/ceros-full-page-takeover.tsx
website/src/pages/ceros-microcontent.tsx

@st0nebreaker st0nebreaker marked this pull request as draft April 21, 2022 23:20
@st0nebreaker st0nebreaker marked this pull request as ready for review May 2, 2022 22:44
@st0nebreaker
Copy link
Contributor Author

This branch is unblocked and ready to be tested by visiting the above url's, @elzannewentzel ! :)

website/src/html.tsx Outdated Show resolved Hide resolved
website/src/pages/ceros-microcontent.tsx Show resolved Hide resolved
Comment on lines +9 to +15
<Helmet>
<script
type="text/javascript"
src="https://view.ceros.com/scroll-proxy.min.js"
data-ceros-origin-domains="https://view.ceros.com/"
/>
</Helmet>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be a good time to create a CerosScript component that you can import and use in Ceros pages so you can reuse the same script and we have one point of reference.

We could eventually even make CerosPage or CerosContent components depending on what the props are.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that idea! This branch isn't being merged in though, since it's just to test our trial with Ceros. I think we should hold off on optimizing the code until we incorporate it more permanently. That sound okay?

Copy link
Contributor

@bretthayes bretthayes May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, definitely, totally agree! Thanks for the extra context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
marketing-request Used by CPT to indicate requests from the Marketing Team
Projects
Status: Not Doing/Cancelled 🗑
Development

Successfully merging this pull request may close these issues.

Test Ceros embed
4 participants