-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ceros test embedded scripts #5282
Conversation
Notifying subscribers in CODENOTIFY files for diff 46f7c1a...b1ae47e.
|
This branch is unblocked and ready to be tested by visiting the above url's, @elzannewentzel ! :) |
<Helmet> | ||
<script | ||
type="text/javascript" | ||
src="https://view.ceros.com/scroll-proxy.min.js" | ||
data-ceros-origin-domains="https://view.ceros.com/" | ||
/> | ||
</Helmet> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a good time to create a CerosScript component that you can import and use in Ceros pages so you can reuse the same script and we have one point of reference.
We could eventually even make CerosPage
or CerosContent
components depending on what the props are.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like that idea! This branch isn't being merged in though, since it's just to test our trial with Ceros. I think we should hold off on optimizing the code until we incorporate it more permanently. That sound okay?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, definitely, totally agree! Thanks for the extra context.
Closes #5272 by embedding some ceros scripts for branch environment troubleshooting.
Note
DON'T MERGE, this is a test for our Ceros trial
Test
/ceros-microcontent
to test the render of ceros microcontent script/ceros-full-page-takeover
to test the render of ceros fullpage takeover script