Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGM-6998 - Add Lucide Icon support #7029

Merged
merged 3 commits into from
Jul 2, 2024
Merged

SGM-6998 - Add Lucide Icon support #7029

merged 3 commits into from
Jul 2, 2024

Conversation

gitstart-app[bot]
Copy link
Contributor

@gitstart-app gitstart-app bot commented Jun 21, 2024

This PR was created by GitStart to address the requirements from this ticket: SGM-6998.
This ticket was imported from: SGM-6998


Description

Implements Lucide-react icon library on the site. Lucide for React

Requirements:

  • Allows use of custom icons
  • Allows use of Lucide Labs
  • Prioritizes page performance and a streamlined build using dynamic imports
  • Enables use of custom props .
  • Enables use of linear gradients in the icon

Demo:

https://www.loom.com/share/78c8221f067d42ca894c6f54b44a3570?sid=904fff2c-6be4-464d-bc74-e5ee8535129b

Test plan:

Run: pnpm install

Navigation: check demo video

Copy link

netlify bot commented Jun 21, 2024

Deploy Preview for sourcegraph ready!

Name Link
🔨 Latest commit ada4d87
🔍 Latest deploy log https://app.netlify.com/sites/sourcegraph/deploys/6684376aac014b00083e7ce7
😎 Deploy Preview https://deploy-preview-7029--sourcegraph.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gitstart-sourcegraph gitstart-sourcegraph self-assigned this Jun 21, 2024
@gitstart-sourcegraph gitstart-sourcegraph linked an issue Jun 21, 2024 that may be closed by this pull request
Copy link
Contributor

@traceyljohnson traceyljohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you resolve the conflicts so we can merge? @gitstart-sourcegraph

@traceyljohnson traceyljohnson merged commit 28442fa into main Jul 2, 2024
6 checks passed
@traceyljohnson traceyljohnson deleted the SGM-6998 branch July 2, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Lucide Icon support
2 participants