Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve YouTube embed code that only shows Sourcegraph videos on end screen #969

Merged
merged 3 commits into from May 21, 2020
Merged

Improve YouTube embed code that only shows Sourcegraph videos on end screen #969

merged 3 commits into from May 21, 2020

Conversation

ryan-blunden
Copy link
Contributor

No description provided.

@ryan-blunden ryan-blunden requested review from a team as code owners May 21, 2020 02:22
@ryan-blunden ryan-blunden self-assigned this May 21, 2020
christinaforney
christinaforney approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@christinaforney christinaforney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you also update the embed example on the blog post template?

@ryan-blunden ryan-blunden merged commit fb5f7fa into master May 21, 2020
@ryan-blunden ryan-blunden deleted the rb-3.16-video-embed-fix branch May 21, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinaforney christinaforney christinaforney approved these changes

@aileenrose aileenrose Awaiting requested review from aileenrose

Assignees

@ryan-blunden ryan-blunden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryan-blunden @christinaforney