Scope DocumentSelector with baseUri

[felixfbecker]

This is a proper fix for both https://github.com/sourcegraph/sourcegraph/issues/8602 and broken codeintel for root files (Slack thread).
Codeintel extensions need to be able to scope providers to workspace roots. Doing so in pattern does not work, because minimatch is not built for working with URIs (in particular it broke for files in the root).

Instead, uses the new baseUri introduced in https://github.com/sourcegraph/sourcegraph/pull/8858.

Closes #295.
Fixes sourcegraph/sourcegraph#8602.

[efritz]

Am I correct that publishing this will break all current instances?

[felixfbecker]

No, it should not. Current instances will ignore the baseUri property. They will just continue to see the double hovers unfortunately until they upgrade to 3.14.

[efritz]

But we’re no longer setting pattern so won’t no providers be registered correctly on old instances?

[felixfbecker]

But the pattern was just root URI + ** before (i.e. all files), and we're still setting language. If the language server provided a pattern we're still passing that through (just "unscoped"), but none of our language servers use that afaik.

[felixfbecker]

(please sanity check what I'm saying, it's late 😅 )

[efritz]

Go to bed I’ll test it later tonight and merge

[efritz]

I ran this and it works neither with DotCom (#8858 has been merged by now and the site version has a rev after that merge commit) nor with a private instance before the merge.

[efritz]

Needs more manual testing.

[felixfbecker]

I'm very confused. I thought the Go issue were fixed by #292 (the revert), and we only had double hovers now?

[felixfbecker]

I found the issue, fix in https://github.com/sourcegraph/sourcegraph/pull/8877. The issue was in the extension host, i.e. the changes in this PR are correct.

Verified that codeintel works: