Skip to content

Commit

Permalink
Feedback: Less log spam. Add TODO about TelemetryService passing.
Browse files Browse the repository at this point in the history
  • Loading branch information
dominiccooney committed Sep 14, 2023
1 parent 9d279c3 commit daf9101
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions vscode/src/services/OnboardingExperiment.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ interface SelectedArm {
setByTestingOverride: boolean
}

// TODO(dpc): Refactor TelemetryService to be a globalton like the other
// services, instead of catching one that's passed around.
let telemetryService: TelemetryService | undefined
let selection: SelectedArm | undefined

Expand Down Expand Up @@ -109,11 +111,6 @@ export function pickArm(useThisTelemetryService: TelemetryService): OnboardingEx
// Try to apply an override for testing.
const overrideSelection = loadOverrideSelection()
if (overrideSelection) {
logDebug(
'simplified-onboarding',
'user override onboarding experiment arm selection',
JSON.stringify(overrideSelection)
)
selection = overrideSelection
return overrideSelection.arm
}
Expand Down

0 comments on commit daf9101

Please sign in to comment.