Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Tooltip on context files says "included via embeddings" even if embeddings not in enhanced context status list #2244

Closed
dominiccooney opened this issue Dec 10, 2023 · 1 comment · Fixed by #2408
Closed

bug: Tooltip on context files says "included via embeddings" even if embeddings not in enhanced context status list #2244

dominiccooney opened this issue Dec 10, 2023 · 1 comment · Fixed by #2408
Assignees
@DanTup
Labels
bug Something isn't working clients/vscode

Comments

@dominiccooney
Copy link
Contributor

Version

Main 9e06caf

Describe the bug

@toolmantim Via Slack: https://sourcegraph.slack.com/archives/C05AGQYD528/p1702248113730479?thread_ts=1702246529.082959&cid=C05AGQYD528

When context is included (probably via editor and/or the "readme" context added by simplified chats) the tooltip in the context list says "included via embeddings" even if embeddings is not involved.

Expected behavior

Tooltip accurately reflects the context source, or at least doesn't misrepresent it.

Additional context

No response
@dominiccooney dominiccooney added bug Something isn't working clients/vscode labels Dec 10, 2023
@dominiccooney
Copy link
Contributor Author

@kalanchan points out this probably originates here:

https://sourcegraph.com/github.com/sourcegraph/cody@9e06cafee3fb60b7e265ced935b2e55b57413838/-/blob/vscode/src/chat/chat-view/chat-helpers.ts?L94

We need to plumb the context origin to that point and promulgate it.

DanTup added a commit that referenced this issue Dec 15, 2023
@DanTup
Use correct file sources instead of always showing 'embeddings' in ch…
7cb5362 
…at context

Fixes #2244
@DanTup DanTup mentioned this issue Dec 15, 2023
Merged
abeatrix added a commit that referenced this issue Jan 8, 2024
@DanTup @abeatrix
Use correct file sources instead of always showing 'embeddings' in ch…
b552a9a 
…at context (#2408)

Fixes #2244

![Screenshot 2023-12-15
182047](https://github.com/sourcegraph/cody/assets/1078012/5ac9ddd3-ac74-49c2-a59e-15be3ca8444e)

![Screenshot 2023-12-15
182154](https://github.com/sourcegraph/cody/assets/1078012/02938d34-471c-4b19-abcd-78b7e0e390ad)

fyi @kalanchan 

## Test plan

- Select text in an editor and run a command like `/explain` that will
include the context file from the editor
- Hover and ensure the tooltip says the file was from the editor, not
embeddings
- Ask something that will cause the readme to be included automatically
- However and ensure the tooltip does not say embeddings

---------

Co-authored-by: Beatrix <beatrix@sourcegraph.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanTup DanTup

Labels
bug Something isn't working clients/vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use correct file sources instead of always showing 'embeddings' in chat context sourcegraph/cody
2 participants
@dominiccooney @DanTup