bug: files in bin/ are filtered out of @-mention in chat

[DanTup]

Version

main 2a00da0

Describe the bug

When I typed @, my open file bin\\main.dart was already in the results, but as I started typing bin it vanished.

bad_filter.mp4

Expected behavior

Files that exist and match my query should not be filtered out.

Additional context

No response

[DanTup]

This turned out to be very specific... The default exclude list includes bin/:

cody/vscode/src/editor/utils/editor-context.ts

Line 16 in 9d48eeb

const fileExcludesPattern = '**/{*.env,.git,out/,dist/,bin/,snap,node_modules,__pycache__}**'

This is something I've hit before... When I did .NET, I would have bin/ in by global gitignore (because in .NET it's compiled binaries). It's quite common in Dart to use bin/ for the entry points of packages:

https://dart.dev/tools/pub/package-layout#:~:text=make_lunch.dart%0A%20%20bin/-,enchilada,-doc/%0A%20%20%20%20api/%20***%0A%20%20%20%20getting_started

@toolmantim any thoughts on this (since you picked the original defaults)? I'm not familiar with how many languages use bin/.. For .NET, probably explicitly including bin/Debug/ and bin/Release/ would filter out the garbage, although perhaps the real fix here is to use gitignore/etc.

[toolmantim]

Best to ask @abeatrix when she’s back, or @beyang — unsure how that initial exclude list was chosen.

[abeatrix]

We can just remove the keyword from the exclude list if the keyword is included in the exclude list, or just remove the exclude list in general from the @ search if you want. I was just using the same exclude list I used for the generate unit test to filter out uncommon files for unit tests and thought the same list could be used, no other particular reasons.

[abeatrix]

I'd recommend keeping it and remove it only if the keyword is included because those files will always show up on top of the list from those folder compared to the actual ones with the same names

[DanTup]

It may look odd if the user is typing @bin/main.dart if it's missing from the list until they've typed @bin/?

I wonder if it should be included (not in the exclude list) but penalised in the ranking unless the query starts with it?

That way if your project is small, it won't be obvious bin/main.dart is missing, but it may be further down the list until you've typed bin/?

[toolmantim]

The fuzzysort ranking algo is easy to tweak, I like the idea of just downscoring it.

[toolmantim]

If we do keep the exclude list, we should probably make it less invisible and hard-coded into the source by moving it to a user setting with the default value. With a cog icon in the popover, similar to the chat window, that opens the settings filtered to this feature.

[DanTup]

Maybe we should switch it to using the ignore file (#1382)? Seems pointless showing the user something in the dropdown to then filter it out later. (that was already done in #1382)

For now, I'll remove bin from the hard-coded ignore list and reduce the relevance.

[DanTup]

I've opened #2472

bin.mp4