-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: files in bin/
are filtered out of @-mention in chat
#2401
Comments
This turned out to be very specific... The default exclude list includes
This is something I've hit before... When I did .NET, I would have @toolmantim any thoughts on this (since you picked the original defaults)? I'm not familiar with how many languages use |
bin/
are filtered out of @-mention in chat
We can just remove the keyword from the exclude list if the keyword is included in the exclude list, or just remove the exclude list in general from the @ search if you want. I was just using the same exclude list I used for the generate unit test to filter out uncommon files for unit tests and thought the same list could be used, no other particular reasons. |
I'd recommend keeping it and remove it only if the keyword is included because those files will always show up on top of the list from those folder compared to the actual ones with the same names |
It may look odd if the user is typing I wonder if it should be included (not in the exclude list) but penalised in the ranking unless the query starts with it? That way if your project is small, it won't be obvious |
The fuzzysort ranking algo is easy to tweak, I like the idea of just downscoring it. |
If we do keep the exclude list, we should probably make it less invisible and hard-coded into the source by moving it to a user setting with the default value. With a cog icon in the popover, similar to the chat window, that opens the settings filtered to this feature. |
I've opened #2472 bin.mp4 |
Fixes #2401 by removing `bin/` from the ignore list and instead just penalizing it unless you have typed `bin` in the query specifically. https://github.com/sourcegraph/cody/assets/1078012/2ad0ef3b-b2f9-45bd-bfc0-54fd77811511 Also applies ignore file to these files ## Test plan - Run `pnpm test:unit` and ensure the new tests pass - Open a project with a file in a folder named `bin` and ensure the file shows up in search results, near the bottom unless you've explicitly typed "bin"
Version
main 2a00da0
Describe the bug
When I typed
@
, my open filebin\\main.dart
was already in the results, but as I started typingbin
it vanished.bad_filter.mp4
Expected behavior
Files that exist and match my query should not be filtered out.
Additional context
No response
The text was updated successfully, but these errors were encountered: