Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It doesn't run on VSCODIUM #3119

Closed
manueleforero opened this issue Feb 9, 2024 · 2 comments · Fixed by #3167
Closed

It doesn't run on VSCODIUM #3119

manueleforero opened this issue Feb 9, 2024 · 2 comments · Fixed by #3167
Assignees
@dominiccooney

Comments

@manueleforero
Copy link

Hi, please i can't install on my EXCELENT VSCODIUM (because your only dispath vscode).

Please fix that editor.
Thanks you.
@baristaGeek
Copy link

I haven't looked at the platform's repo. But based on the fact that when you log in via OAuth to any service (GitHub, Google, etc.) on VS Codium you get redirected to VS Code, I'm guessing the solution is making the platform pass a parameter to modify the URI that will open either VS Code or VS Codium

@dominiccooney
Copy link
Contributor

Looks like we need to use vscodium:// as the scheme instead of vscode:// or vscode-insiders://. We'll need to change the Sourcegraph frontend to allow redirects to this scheme, or use http:// like JetBrains.

This was referenced Feb 14, 2024
Merged
Merged
@dominiccooney dominiccooney self-assigned this Feb 14, 2024
@beyang beyang assigned abeatrix and unassigned dominiccooney Feb 14, 2024
dominiccooney added a commit to sourcegraph/sourcegraph that referenced this issue Feb 15, 2024
@dominiccooney @abeatrix
Enable auth token redirects to VSCodium (#60515)
013574e 
Part of sourcegraph/cody#3119

## Test plan

1. `sg start dotcom`
2. Open a browser, navigate to `https://sourcegraph.test:3443/.auth/openidconnect/login?prompt_auth=github&pc=sams&redirect=/post-sign-up?returnTo=/user/settings/tokens/new/callback?requestFrom=CODY_VSCODIUM`
3. Sign in, for example user: sourcegraph, pass: sourcegraphsourcegraph
4. Fill out the sign on survey
5. Verify that you are redirected to a link like `vscodium://sourcegraph.cody-ai/...` etc. If you have VSCodium installed, this will open VSCodium.

Co-authored-by: Beatrix <68532117+abeatrix@users.noreply.github.com>
dominiccooney added a commit that referenced this issue Feb 15, 2024
@dominiccooney
VSCode: Support login redirects in VSCodium (#3167)
a84d883 
VSCodium is a fork of VSCode. It uses a different URI scheme for app
links; as a result, our login flow does not work in VSCodium. This
changes the login querystring parameter so the browser-based auth flow
can redirect to VSCodium when the flow is complete.

sourcegraph/sourcegraph#60515 is the related server-side change.

Fixes #3119, #2704

## Test plan

Manually test that login URLs have the CODY_VSCODIUM parameter in
VSCodium:

1. `CODY_RELEASE_TYPE=stable pnpm -C vscode release:dry-run`
2. Install [VSCodium](https://vscodium.com/), run it.
3. Extensions, ..., Install from VSIX...
4. Pick `vscode/dist/cody.vsix`
5. Click the GitHub login button. You should get directed to a URL like:
`https://sourcegraph.com/.auth/openidconnect/login?prompt_auth=github&pc=sams&redirect=/post-sign-up?returnTo=/user/settings/tokens/new/callback?requestFrom=CODY_VSCODIUM`
(note the *VSCODIUM* part.)
@abeatrix abeatrix assigned dominiccooney and unassigned abeatrix Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dominiccooney dominiccooney

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VSCode: Support login redirects in VSCodium sourcegraph/cody
4 participants
@dominiccooney @baristaGeek @manueleforero @abeatrix