VSCode: Support login redirects in VSCodium #3167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominiccooney
force-pushed
the
dpc/vscodium
branch
from
3d2f10b
to
72b8ec1
Compare
abeatrix
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VSCodium is a fork of VSCode. It uses a different URI scheme for app links; as a result, our login flow does not work in VSCodium. This changes the login querystring parameter so the browser-based auth flow can redirect to VSCodium when the flow is complete.
sourcegraph/sourcegraph#60515 is the related server-side change.
Fixes #3119, #2704
Test plan
Manually test that login URLs have the CODY_VSCODIUM parameter in VSCodium:
CODY_RELEASE_TYPE=stable pnpm -C vscode release:dry-runvscode/dist/cody.vsixhttps://sourcegraph.com/.auth/openidconnect/login?prompt_auth=github&pc=sams&redirect=/post-sign-up?returnTo=/user/settings/tokens/new/callback?requestFrom=CODY_VSCODIUM(note the VSCODIUM part.)