Autocomplete: Add alt+\ shortcut to trigger autocomplete and bypass debouncing times #1060
Conversation
philipp-spiess
changed the title
| @@ -22,6 +22,8 @@ Starting from `0.2.0`, Cody is using `major.EVEN_NUMBER.patch` for release versi | |||
| - Enabled streaming responses for all autocomplete requests. [pull/995](https://github.com/sourcegraph/cody/pull/995) | |||
| - Sign out immediately instead of showing the quick-pick menu. [pull/1032](https://github.com/sourcegraph/cody/pull/1032) | |||
| - UX improvements to the custom command workflow (and new [custom command docs](https://docs.sourcegraph.com/cody/custom-commands)). [pull/992](https://github.com/sourcegraph/cody/pull/992) | |||
| - You can now use `alt` + `\` to trigger autocomplete requests manually. [pull/1060](https://github.com/sourcegraph/cody/pull/1060) | |||
| - Slightly reduce latency when manually triggering autocomplete requests. [pull/1060](https://github.com/sourcegraph/cody/pull/1060) | |||
There was a problem hiding this comment.
Can you elaborate more on how this change reduces latency, please?
There was a problem hiding this comment.
This is related to this code change: https://github.com/sourcegraph/cody/pull/1060/files#diff-0bf82c65c27367a15630425d194c46f5a66bae138f46c63361027b00161c1720R208-R212
Previously, manually triggered completions (so either using the new shortcut or by hovering over a completed text to see all possible results) would still have waited for the small 25ms/125ms debounce time - That time is so that we don't trigger toooo many network requests while typing to save some money. However for manually invoked completions we don't need that because they are already very low in volume + they are a strong sign that you want a completion NOW.
There was a problem hiding this comment.
@abeatrix let me know if this makes sense 🙂
|
@philipp-spiess Should this bypass other restrictions too? E.g. this code: We don't produce completions here as we've discussed before, but if I forcibly request it - that might be useful? Unsure if there's a way to pick up on how the completion was triggered |
Closes #1019
This adds the manual completion shortcut to trigger completions.
This change also disables the debounce timings when the completion was manually requested (that is, either using this shortcut or when hovering over completions). This is done to slightly increase latency when we already have a strong sign that the user really wants that completion
Test plan
Screen.Recording.2023-09-14.at.15.20.11.mov