/symf: remove direct anthropic dependency, pass sourcegraph token #1207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyang
force-pushed
the
bl/symf-sg-auth
branch
2 times, most recently
from
ebba582
to
7e87b8c
Compare
beyang
force-pushed
the
bl/symf-sg-auth
branch
from
7e87b8c
to
cda77e9
Compare
|
@beyang I've been running this branch but when I run the Screen.Recording.2023-09-27.at.13.46.47.mov |
| @@ -107,7 +107,7 @@ const register = async ( | |||
| disposables.push(vscode.workspace.onDidChangeTextDocument(updateParseTreeOnEdit)) | |||
| } | |||
|
|
|||
| const symfRunner = platform.createSymfRunner?.(context, config.experimentalSymfAnthropicKey) | |||
| const symfRunner = platform.createSymfRunner?.(context, initialConfig.accessToken) | |||
There was a problem hiding this comment.
Have you looked into the chatClient available in the scope here?
There was a problem hiding this comment.
Oh nevermind you need that in the symf binary 🤦
There was a problem hiding this comment.
symf currently issues its own query to transform the user query into a keyword search... I suppose we could move that out of symf into Cody/agent and then symf could focus solely on keyword search. Perhaps in a future PR.
philipp-spiess
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
symftalked directly to the Anthropic API. Now, it goes through a Sourcegraph instance to access the LLM. This PR updates Cody to pass the Sourcegraph auth token tosymfand removes the old code for setting an Anthropic API token.Test plan
Test locally:
Check out the main branch
Remove any
cody.experimental.symf.anthropicKeyin your settings.Try running
/symf [query]. You should see an error indicating thatsymfis unauthorized.Check out this branch and run the extension
In the sidebar, run
/symf [query], where query is either a keyword search or a natural language questionsymf(v0.0.1) is being downloadedYou should see successful search results