Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Commands: Fix custom command menu not showing for a single custom command #1532

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

toolmantim
Copy link
Contributor

@toolmantim toolmantim commented Oct 27, 2023

The Custom Commands action shows the incorrect menu (the generic custom commands config quickpick) if you only have a single custom command defined, due to an off-by-one. This fixes it so it shows the correct menu.

Test plan

  • Created a single custom command. Tested the action.

@toolmantim toolmantim requested review from abeatrix and a team October 27, 2023 12:04
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@toolmantim toolmantim enabled auto-merge (squash) October 31, 2023 04:13
@toolmantim toolmantim merged commit 0b1a7a6 into main Oct 31, 2023
14 checks passed
@toolmantim toolmantim deleted the tl/fix-custom-command-menu-not-showing-for-1-command branch October 31, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants