Edit: Quality improvements: Add related fix context when available
#1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
changed the title
fix context when availablefix context when available
umpox
added a commit
that referenced
this pull request
Nov 14, 2023
Part of #1544 Part of #1464 ## Description "Ask Cody to Fix" is one of the most common command actions we currently have. It makes sense to support this better instead of treating this like a normal "edit" - Skip fetching context, from my personal testing it very rarely helps. Most information is contained within the error, or is part of `relatedInformation` attached to the diagnostic - We can start fetching more relevant context from sources directly related to the fix: #1723 - Use a more targeted prompt preamble to address the task ## Test plan - Fixups without code actions (edit/document/edit with no selection) - Fixups through code action (Ask Cody to Fix) <!-- Required. See https://docs.sourcegraph.com/dev/background-information/testing_principles. -->
umpox
force-pushed
the
tr/better-fix-context
branch
from
5279070
to
b73235a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some improvements to "fix":
sourcewhen available, e.g. "typescript" for better prompt instruction.relatedInformationdiagnostic from VS Code:messageTest plan
Run code actions manually (I need to add eval cases to make this easier)