Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit: Faster code action fixes #1639

Merged
merged 11 commits into from
Nov 14, 2023
Merged

Edit: Faster code action fixes #1639

merged 11 commits into from
Nov 14, 2023

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Nov 6, 2023

Part of #1544
Part of #1464

Description

"Ask Cody to Fix" is one of the most common command actions we currently have.

It makes sense to support this better instead of treating this like a normal "edit"

  • Skip fetching context, from my personal testing it very rarely helps. Most information is contained within the error, or is part of relatedInformation attached to the diagnostic
  • Use a more targeted prompt preamble to address the task

Test plan

  • Fixups without code actions (edit/document/edit with no selection)
  • Fixups through code action (Ask Cody to Fix)

@umpox umpox changed the title Handle code actions Edit: Faster code action fixes Nov 6, 2023
@umpox umpox marked this pull request as ready for review November 13, 2023 10:53
@umpox umpox requested review from abeatrix and a team November 13, 2023 11:02
@umpox umpox self-assigned this Nov 13, 2023
Copy link
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍 Looking forward to trying it together with #1723!

@umpox umpox enabled auto-merge (squash) November 14, 2023 10:01
@umpox umpox merged commit d81fe90 into main Nov 14, 2023
14 checks passed
@umpox umpox deleted the tr/faster-edits branch November 14, 2023 10:22
@umpox umpox assigned umpox and unassigned umpox Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants