Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete: Move decision which StarCoder model to use to the server #1845

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

philipp-spiess
Copy link
Contributor

Follow up to sourcegraph/sourcegraph#58404

This PR moves the client logic of picking the right StarCoder model to the server.

Test plan

Screenshot 2023-11-21 at 13 24 21

@philipp-spiess philipp-spiess requested review from rafax and a team November 21, 2023 12:29
@philipp-spiess philipp-spiess self-assigned this Nov 21, 2023
Copy link
Contributor

@rafax rafax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think PR (in isolation) removes the ability to switch between MT and ST models on the client (but doesn't add server switching)? If so, it might make sense to include that for future readers.

@philipp-spiess
Copy link
Contributor Author

PR (in isolation) removes the ability to switch between MT and ST models on the client (but doesn't add server switching)? If so, it might make sense to include that for future readers.

Correct but since this was only enabled for dotcom and dotcom has already updated, users will not have an observable effect.

@philipp-spiess philipp-spiess merged commit ed61944 into main Nov 21, 2023
14 checks passed
@philipp-spiess philipp-spiess deleted the ps/ac-mv-sc-model-decision-to-server branch November 21, 2023 16:03
philipp-spiess added a commit that referenced this pull request Nov 27, 2023
#1845)

Follow up to sourcegraph/sourcegraph#58404

This PR moves the client logic of picking the right StarCoder model to
the server.

## Test plan

<img width="1258" alt="Screenshot 2023-11-21 at 13 24 21"
src="https://github.com/sourcegraph/cody/assets/458591/ec5dab09-c41c-4d04-b759-38864ab50cf8">


<!-- Required. See
https://docs.sourcegraph.com/dev/background-information/testing_principles.
-->
philipp-spiess added a commit that referenced this pull request Nov 27, 2023
This release is only shipping #1845

## Test plan

Ensure merge-back only has version bump and changelog updates

<!-- Required. See
https://docs.sourcegraph.com/dev/background-information/testing_principles.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants