-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle chat command selection logic #1980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to work, but the chat transcript seems to render the @-file token inconsistently:
![Screenshot 2023-11-29 at 10 20 21 pm](https://private-user-images.githubusercontent.com/153/286576528-d89ecf9a-c7d3-4a3a-b433-c814c75bfd37.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2MjA2MjksIm5iZiI6MTcyMTYyMDMyOSwicGF0aCI6Ii8xNTMvMjg2NTc2NTI4LWQ4OWVjZjlhLWM3ZDMtNGEzYS1iNDMzLWM4MTRjNzViZmQzNy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNzIyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDcyMlQwMzUyMDlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iYWVhYWM2MjlkMTI4NjMwYjExMjI2NzFiMmEwMTY0NDczYjgyMzIxNGFkNjc1NTUwYzhlYzJlNGZmNTUyZTc5JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.trdE2OdJ2_3SYU-25jrBPzpaFOAjH9tSaQaB96fT4bY)
Ideally we'd make the context file selector disappear when they type that additional character (e.g. in the below video, it would disappear again when they type ?
). It sticking on and capturing Enter events feels a bit buggy.
Screen.Recording.2023-11-29.at.10.23.25.pm.mov
@toolmantim can you take another look at the latest commit and let me know if that works the way you have in mind please? 🙇♀️ Screen.Recording.2023-11-29.at.10.30.24.AM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great! Thanks @abeatrix ✨
CLOSE #1973
Address the
/
command bug mentioned in #1968Test plan
Before
After
Before
slash command can be activated when you paste a paragraph with space to the chat inbox in a new chat, even if the paragraph doesn't starts with a /
Screen.Recording.2023-11-28.at.11.14.35.PM.mov
After
Pasting anything that doesn't start with / will not trigger the selection box
Screen.Recording.2023-11-28.at.11.14.58.PM.mov