Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle chat command selection logic #1980

Merged
merged 8 commits into from
Nov 29, 2023
Merged

Conversation

abeatrix
Copy link
Contributor

CLOSE #1973
Address the / command bug mentioned in #1968

Test plan

Before

image

After

image

Before

slash command can be activated when you paste a paragraph with space to the chat inbox in a new chat, even if the paragraph doesn't starts with a /

image
Screen.Recording.2023-11-28.at.11.14.35.PM.mov

After

Pasting anything that doesn't start with / will not trigger the selection box

image
Screen.Recording.2023-11-28.at.11.14.58.PM.mov

@abeatrix abeatrix requested a review from a team November 29, 2023 07:20
Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to work, but the chat transcript seems to render the @-file token inconsistently:

Screenshot 2023-11-29 at 10 20 21 pm

Ideally we'd make the context file selector disappear when they type that additional character (e.g. in the below video, it would disappear again when they type ?). It sticking on and capturing Enter events feels a bit buggy.

Screen.Recording.2023-11-29.at.10.23.25.pm.mov

@abeatrix
Copy link
Contributor Author

abeatrix commented Nov 29, 2023

This seems to work, but the chat transcript seems to render the @-file token inconsistently:

Ideally we'd make the context file selector disappear when they type that additional character (e.g. in the below video, it would disappear again when they type ?). It sticking on and capturing Enter events feels a bit buggy.

Screen.Recording.2023-11-29.at.10.23.25.pm.mov

@toolmantim can you take another look at the latest commit and let me know if that works the way you have in mind please? 🙇‍♀️

Screen.Recording.2023-11-29.at.10.30.24.AM.mov

Copy link
Contributor

@toolmantim toolmantim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great! Thanks @abeatrix

@abeatrix abeatrix merged commit db5f6f2 into main Nov 29, 2023
14 checks passed
@abeatrix abeatrix deleted the bee/fix-input-selection branch November 29, 2023 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: hitting backspace after @-including a file shouldn't lose the file context
2 participants