bug: Chat history gets overwritten when there is a new chat #1968
Assignees
Labels
Comments
abeatrix
added a commit
that referenced
this issue
Nov 29, 2023
CLOSE #1973 Address the `/` command bug mentioned in #1968 - Update the chat command selection logic to only filter commands when the input starts with a '/' instead of splitting the input value. (re #1968) - Also update the file completion logic to better preserve the existing input value. (re #1973) ## Test plan <!-- Required. See https://docs.sourcegraph.com/dev/background-information/testing_principles. --> ### Before <img width="809" alt="image" src="https://github.com/sourcegraph/cody/assets/68532117/def29a1e-30a1-419e-b309-d935777fd7a6"> ### After <img width="816" alt="image" src="https://github.com/sourcegraph/cody/assets/68532117/92e52749-2f39-4dcb-9e94-6ecc3fe3c126"> ### Before slash command can be activated when you paste a paragraph with space to the chat inbox in a new chat, even if the paragraph doesn't starts with a / <img width="816" alt="image" src="https://github.com/sourcegraph/cody/assets/68532117/949284d2-96c4-447b-93dc-0aa45685ddd3"> https://github.com/sourcegraph/cody/assets/68532117/b9453516-3fbf-423c-bb1f-e2a528fb5e6d ### After Pasting anything that doesn't start with / will not trigger the selection box <img width="805" alt="image" src="https://github.com/sourcegraph/cody/assets/68532117/f373e93b-5cca-44c9-a2b9-f96b2fa3c56a"> https://github.com/sourcegraph/cody/assets/68532117/14ba71f0-af7e-497b-84f0-ad1daf6bb97e
abeatrix
changed the title
abeatrix
added a commit
that referenced
this issue
Dec 4, 2023
CLOSE #1968 This PR focused on simplify chat history handling by moving the old chat history handling in MessageProvider to the new Chat History Manager. Removed redundant chat history code and use shared chatHistory module instead. This simplifies the MessageProvider by removing duplicated chat history logic. This also fixes issue described in the attached issue as previously, we would save chat history as group instead of individual chat, so a new group can overwritten the old one, unable to keep history across panels in sync. ## Test plan <!-- Required. See https://docs.sourcegraph.com/dev/background-information/testing_principles. --> Follow instructions in attached issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Version
v0.17.1701184011
Describe the bug
Cody chat history gets overwritten when you have an active chat as well.
Expected behavior
See the video.
/-menu shows up and I can't dismiss it)In step 5, the old chat's history has been overwritten with the new message from the new chat.
cody-chat-history-broken-20231128.mp4
Additional context
No response
The text was updated successfully, but these errors were encountered: