fix: migrate to chat history manager #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| await this.saveTranscriptToChatHistory() | ||
| this.cancelCompletion() | ||
| const history = chatHistory.getChat(chatID) | ||
| if (!history || chatID === this.sessionID) { |
There was a problem hiding this comment.
Just curious when chatID == this.sessionID would happen.
| await localStorage.removeChatHistory() | ||
| } | ||
|
|
||
| public async saveInput(input: string): Promise<UserLocalHistory> { |
There was a problem hiding this comment.
Worth a brief comment that this saves human input for the "up" history list, and same for getInput. Because there's a few methods running around with "save" this or that.
There was a problem hiding this comment.
updated name to save/getHumanInputHistory and added comment
kalanchan
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE #1968
This PR focused on simplify chat history handling by moving the old chat history handling in MessageProvider to the new Chat History Manager.
Removed redundant chat history code and use shared chatHistory module instead. This simplifies the MessageProvider by removing duplicated chat history logic.
This also fixes issue described in the attached issue as previously, we would save chat history as group instead of individual chat, so a new group can overwritten the old one, unable to keep history across panels in sync.
Test plan
Follow instructions in attached issue