Edit: Fix malformed comments from doc command with selection #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
commented
Dec 12, 2023
| @@ -235,5 +232,10 @@ function getDocCommandRange( | |||
| } | |||
| } | |||
|
|
|||
| return new vscode.Selection(pos, pos) | |||
There was a problem hiding this comment.
This was the offending line (overriding the entire range rather than just the start).
Once we're out for GA I think we should improve our integration tests around all the entry points for commands to help catch stuff like this, lots of variants depending on if there's a selection/the language/the command
|
Follow up for a related scroll bug: #2296 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #2058
getDocCommandRangefor the/doccommand was returning the incorrect selection. It was overriding the end position rather than just adjusting the start position for python.This meant that the edit command was treating this as an
add(no selected code thus nothing to edit)Before
DocMalformBefore.mov
After
MalformDocAfter.mov
Test plan