fix: use default selection range for python doc #2143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipp-spiess
approved these changes
Dec 6, 2023
vscode/src/commands/CommandRunner.ts
Outdated
| @@ -217,12 +217,8 @@ export function addSelectionToPrompt(prompt: string, code: string): string { | |||
| * | |||
There was a problem hiding this comment.
The comment is now outdated 😬
toolmantim
reviewed
Dec 6, 2023
woops i misunderstood the issue. thought you wanted it above the function name instead of below it, my bad 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE #2100
The getDocCommandRange function that is used for setting the range for the /doc comment was modified to always return the default selection range instead of trying to move to the line below the function for python.
Test plan
Try to run the doc command in python code, the doc string should be added above the function name instead of below