Edit: Do not scroll into view on complete #2297
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2259
Description
Previously we would always scroll a completed task into view on completion.
We have a bug with this already (#2259).
One fix here is just to scroll this into view when the code is NOT already in view.
However, I think this might actually be annoying behaviour. The user already gets a notification for edits that are made if the file is not currently active. It seems overly aggressive to force their scroll back to the code when editing an active file.
Test plan