Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit: Do not scroll into view on complete #2297

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Dec 12, 2023

closes #2259

Description

Previously we would always scroll a completed task into view on completion.

We have a bug with this already (#2259).

One fix here is just to scroll this into view when the code is NOT already in view.

However, I think this might actually be annoying behaviour. The user already gets a notification for edits that are made if the file is not currently active. It seems overly aggressive to force their scroll back to the code when editing an active file.

Test plan

  1. Edit code in a large file
  2. Scroll the code out of view
  3. Check we don't hijack the scroll

@umpox umpox requested review from taylorsperry and a team December 12, 2023 11:10
Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@umpox umpox merged commit db9cfec into main Dec 12, 2023
13 checks passed
@umpox umpox deleted the tr/edit-command-jump-on-completre branch December 12, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: "Ask Cody to Fix" jumps when fix applied
2 participants