Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "Ask Cody to Fix" jumps when fix applied #2259

Closed
taylorsperry opened this issue Dec 11, 2023 · 1 comment · Fixed by #2297
Closed

bug: "Ask Cody to Fix" jumps when fix applied #2259

taylorsperry opened this issue Dec 11, 2023 · 1 comment · Fixed by #2297
Assignees
Labels
bug Something isn't working clients/vscode

Comments

@taylorsperry
Copy link
Contributor

Version

v0.19.1702220762

Describe the bug

"Ask Cody to Fix" jumps when fix applied. See Loom at 0:28. Also seems pretty slow?

Expected behavior

Shouldn't jump when edits are applied.

Additional context

No response

@taylorsperry taylorsperry added bug Something isn't working clients/vscode labels Dec 11, 2023
@umpox umpox self-assigned this Dec 12, 2023
@umpox
Copy link
Contributor

umpox commented Dec 12, 2023

Related: #2259

umpox added a commit that referenced this issue Dec 12, 2023
closes #2259

## Description

Previously we would always scroll a completed task into view on
completion.

We have a bug with this already
(#2259).

One fix here is just to scroll this into view when the code is NOT
already in view.

However, I think this might actually be annoying behaviour. The user
already gets a notification for edits that are made if the file is not
currently active. It seems overly aggressive to force their scroll back
to the code when editing an active file.

## Test plan

1. Edit code in a large file
2. Scroll the code out of view
3. Check we don't hijack the scroll


<!-- Required. See
https://docs.sourcegraph.com/dev/background-information/testing_principles.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working clients/vscode
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants