Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat: Fix settings menu not opening on click #2346

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

umpox
Copy link
Contributor

@umpox umpox commented Dec 13, 2023

Description

closes #2317

This is something else which was covered in the chat logic but hasn't been lifted over to here yet

Before

image

After

image

Test plan

Click this button

image

Check menu opens

@umpox umpox requested review from a team December 13, 2023 15:45
@umpox umpox enabled auto-merge (squash) December 13, 2023 15:46
@umpox umpox merged commit 2156f50 into main Dec 13, 2023
16 checks passed
@umpox umpox deleted the tr/fix-settings-menu branch December 13, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Command settings button in the chat slash command popover fails with error
2 participants