Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Command settings button in the chat slash command popover fails with error #2317

Closed
toolmantim opened this issue Dec 13, 2023 · 0 comments · Fixed by #2346
Closed

bug: Command settings button in the chat slash command popover fails with error #2317

toolmantim opened this issue Dec 13, 2023 · 0 comments · Fixed by #2346
Assignees
@umpox
Labels
bug Something isn't working clients/vscode

Comments

@toolmantim
Copy link
Contributor

Version

main 891d525

Describe the bug

Clicking the settings button in the chat slash command popover shows an error.

Screen.Recording.2023-12-13.at.11.01.29.am.mov

Repo steps:

  • New chat
  • Type / in the message input
  • Click the cog button to the right of "Commands"

Expected behavior

When you click the cog button the custom commands setting quickpick opens

Additional context

No response
@toolmantim toolmantim added bug Something isn't working clients/vscode labels Dec 13, 2023
@toolmantim toolmantim changed the title bug: Command settings button in the chat slash command popover button shows an error bug: Command settings button in the chat slash command popover shows an error Dec 13, 2023
@toolmantim toolmantim changed the title bug: Command settings button in the chat slash command popover shows an error bug: Command settings button in the chat slash command popover fails with error Dec 13, 2023
@umpox umpox self-assigned this Dec 13, 2023
@umpox umpox mentioned this issue Dec 13, 2023
Merged
umpox added a commit that referenced this issue Dec 13, 2023
@umpox
Chat: Fix settings menu not opening on click (#2346)
2156f50 
## Description

closes #2317

This is something else which was covered in the chat logic but hasn't
been lifted over to here yet

### Before 


![image](https://github.com/sourcegraph/cody/assets/9516420/9cbcb24e-b42c-4523-81b4-b36cf262e36c)

### After

<img width="673" alt="image"
src="https://github.com/sourcegraph/cody/assets/9516420/189c0d58-da34-4e78-803e-754a9deab6fc">


## Test plan

Click this button

<img width="248" alt="image"
src="https://github.com/sourcegraph/cody/assets/9516420/816d725c-7d55-4728-b248-ef04d0f7f8c0">

Check menu opens

<!-- Required. See
https://docs.sourcegraph.com/dev/background-information/testing_principles.
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@umpox umpox

Labels
bug Something isn't working clients/vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chat: Fix settings menu not opening on click sourcegraph/cody
2 participants
@toolmantim @umpox