Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embeddings: Display accurate percent done; do not toast continued embeddings failure #2368

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

dominiccooney
Copy link
Contributor

@dominiccooney dominiccooney commented Dec 14, 2023

  • Do not display "Cody Embeddings Index Complete" if there's an error from the last local embeddings indexing attempt.
  • Display the local embeddings percent complete in the status bar. Previously we displayed the percent incomplete.

Test plan

See https://www.loom.com/share/869556cee0dc42e4b1694f924c9e61fd?sid=8234ac0d-c984-4def-a31f-5d474d5b294d

  1. Sign in with a rate-limited token.
  2. Generate an incomplete embeddings index by opening a repo without embeddings, starting chat, enabling embeddings, and let it hit the rate limit. Alternatively, kill the cody-engine process and reload VSCode.
  3. The status bar should indicate an appropriate, low percentage completion.
  4. Resume indexing to hit the failure again. You should not see a sparkle toast that the index is complete when indexing fails.
  5. Sign in with an account which can generate embeddings and resume indexing again.
  6. The index should complete and you see a sparkle toast.

Copy link
Contributor

@philipp-spiess philipp-spiess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🤗

@dominiccooney dominiccooney merged commit d23b00a into main Dec 14, 2023
14 checks passed
@dominiccooney dominiccooney deleted the dpc/do-not-toast-failure branch December 14, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants