Autocomplete: Remove obvious prompt-continuations #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeatrix
approved these changes
Jan 31, 2024
|
@abeatrix Can you clarify this question? This is going to hide those bad responses but they can still happen. In practice though, this doesn't seem to happen often. Would be insightful to have analytics though how many things we filter out with these checks |
chwarwick
approved these changes
Jan 31, 2024
philipp-spiess
added a commit
that referenced
this pull request
Feb 1, 2024
Closes #2912 If the completion is very obviously a prompt continuation, we should not show it. I noticed this too a bunch of time with `// Path: ...` style completions in StarCoder. ## Test plan - Added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2912
If the completion is very obviously a prompt continuation, we should not show it. I noticed this too a bunch of time with
// Path: ...style completions in StarCoder.Test plan