-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature flags: Add a way to subscribe to feature flag changes #2992
Conversation
This has been much more involved than I initially thought. There's still some kind of race condition in there that I don't fully understand. I think I'll refactor the feature flag provider to not mix "undefined" feature flags with the preloaded feature flag object but instead cache them in a different object. 😓 cc @valerybugakov if you have any input |
Yes, please! Based on our recent discussion this part is tricky to reason about. Making it more transparent and robust would be great. |
@valerybugakov This is ready for review now, I addressed the point I mentioned above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! and v helpful for future experiments. Thanks for adding the tests
vscode/CHANGELOG.md
Outdated
@@ -6,6 +6,15 @@ This is a log of all notable changes to Cody for VS Code. [Unreleased] changes a | |||
|
|||
### Added | |||
|
|||
- Chat: Display Cody icon in the editor title of the chat panels when `cody.editorTitleCommandIcon` is enabled. [pull/2937](https://github.com/sourcegraph/cody/pull/2937) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a bad merge, needs updating!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch, ty!
Adds a new method to the feature flag provider in order to subscribe to changes for a specific prefix and subscribes the autocomplete codebase to all
cody.autocomplete
changes. When triggered, it will re-initialize just like when settings are changed.The main motivation is that we want to be able to change experiment rollouts without having to wait for days until all users have reloaded the VS Code extension.
Test plan