speed up & respect ignores in finding workspace files for file @-mentions #3433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sqs
force-pushed
the
sqs/faster-find-file
branch
from
738cbaa
to
765afc8
Compare
sqs
changed the title
sqs
force-pushed
the
sqs/faster-find-file
branch
4 times, most recently
from
abe0eec
to
dec6cbb
Compare
1. Finding the list of files now respects the `files.exclude`, `search.exclude`, and gitignore/ignore files. This makes it much faster (~1200ms -> 100ms on sourcegraph/sourcegraph on my machine) and eliminates irrelevant files (such as tons of `bazel-bin/` and `*.js` files). 2. Removes the cancellation on `throttledFindFiles`. This actually made it slower because each time `throttledFindFiles.cancel()` was called, it would invalidate the cached result, which means the next call would invoke the expensive find-files operation even if it had been less than 10000ms since the previous successful call. We do not need cancellation for this operation because each call uses the same arguments, so earlier calls are not wasted and just mean the result will be returned slightly sooner. Note: the e2e tests change because the `.gitignore` in the vscode/test/fixtures/workspace dir is now respected, so there is one less item in the dropdown. This is an enhancement.
sqs
force-pushed
the
sqs/faster-find-file
branch
from
dec6cbb
to
8b462f2
Compare
|
|
philipp-spiess
approved these changes
Mar 18, 2024
There was a problem hiding this comment.
Awesome stuff. I hope we can get the better file api to clean up some of this.
Also this doesn't pull in nested gitignore files yet making it less useful on repos with more than one project but I don't know if it's worth it preemtively looking at every ignore file in the workspace and building a giant ignore list just to support that. 😐
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
files.exclude,search.exclude, and gitignore/ignore files. This makes it much faster(~1200ms -> 100ms on sourcegraph/sourcegraph on my machine) and eliminates
irrelevant files (such as tons of
bazel-bin/and*.jsfiles).throttledFindFiles. This actually made itslower because each time
throttledFindFiles.cancel()was called, it wouldinvalidate the cached result, which means the next call would invoke the
expensive find-files operation even if it had been less than 10000ms since
the previous successful call. We do not need cancellation for this
operation because each call uses the same arguments, so earlier calls are
not wasted and just mean the result will be returned slightly sooner.
Note: the e2e tests have 1 change because the
.gitignorein the vscode/test/fixtures/workspace dir is now respected, so there is one less item in the dropdown. This is an enhancement.Before
After
Test plan
CI