Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: share at mention logics between edit and chat #3498

Merged
merged 1 commit into from Mar 22, 2024

Conversation

abeatrix
Copy link
Contributor

@abeatrix abeatrix commented Mar 21, 2024

Follow up on my command in #3494

Updated to share the duplicated at-mention labels and logic to fetch for at-mention context items between edit and chat.

This also adds the missing support for URL as context item to Edit:

image

Test plan

Green CI

Copy link
Contributor

@umpox umpox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!!

@umpox umpox merged commit d63dcca into tr/show-file-warning-edit Mar 22, 2024
17 of 21 checks passed
@umpox umpox deleted the bee/share-atmention branch March 22, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants