-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit: Show warning on files that are too large #3494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works smoothly! Left some comments inline.
I think some of the logics are duplicated and can be shared between chat and edit, we should work on that in a follow-up 😄
@abeatrix Awesome, thank you. I noticed a bug where symbol results don't show at all for edit or chat, when using |
closes #2965
Description
This PR:
Test plan