Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH Actions for Analytics Telemetry Checks #3912

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/telemetry-check.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Analytics Telemetry Check

on:
pull_request:
branches:
- main

jobs:
check-for-deprecated-v1-telemetry:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3

- name: Check for deprecated telemetry calls
shell: bash
run: |
echo "Checking for deprecated telemetry calls"
# ToDo: test below before pushing
echo "logEvent('this should get flagged')"
if grep -rEn 'logEvent|logEvents|eventLogger\.log' .; then
echo "Found log events in the following files:"
grep -rEn 'logEvent|logEvents|eventLogger\.log' . | while read -r line ; do
file=$(echo "$line" | cut -d':' -f1) match=$(echo "$line" | cut -d':' -f2-)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: weird spacing here

echo "File: $file, Match: $match"
done
exit 1
else
echo "No log events found in modified files."
exit 0
fi