Add GH Actions for Analytics Telemetry Checks #3912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhchabran
reviewed
Apr 24, 2024
| if grep -rEn 'logEvent|logEvents|eventLogger\.log' .; then | ||
| echo "Found log events in the following files:" | ||
| grep -rEn 'logEvent|logEvents|eventLogger\.log' . | while read -r line ; do | ||
| file=$(echo "$line" | cut -d':' -f1) match=$(echo "$line" | cut -d':' -f2-) |
|
This PR is marked as stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed automatically in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new GitHub workflow that runs tests to monitor telemetry events getting logged. The tests will flag when the deprecated v1 telemetry is being used as well as validate best practices are being followed
Test plan
Validate via GH actions on PR build