Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swallow hidePopover exception #4062

Merged
merged 1 commit into from
May 6, 2024
Merged

swallow hidePopover exception #4062

merged 1 commit into from
May 6, 2024

Conversation

sqs
Copy link
Member

@sqs sqs commented May 6, 2024

Attempt to fix issue reported by 2 people where the Cody webview was blank in VS Code and the following error appeared in the devtools console:

Uncaught DOMException: Failed to execute 'hidePopover' on 'HTMLElement': Invalid on popover elements that aren't already showing. This might have been the result of the "beforetoggle" event handler changing the state of this popover.

Test plan

CI

@sqs sqs requested a review from a team May 6, 2024 18:52
Attempt to fix issue reported by 2 people where the Cody webview was blank in VS Code and the following error appeared in the devtools console:

```
Uncaught DOMException: Failed to execute 'hidePopover' on 'HTMLElement': Invalid on popover elements that aren't already showing. This might have been the result of the "beforetoggle" event handler changing the state of this popover.
```
@sqs sqs enabled auto-merge (squash) May 6, 2024 18:56
@sqs sqs merged commit e9992de into main May 6, 2024
20 checks passed
@sqs sqs deleted the sqs/fix-hidepopover branch May 6, 2024 18:59
abeatrix pushed a commit that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants