Tutorial: Handle auth __after__ we sync #4108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valerybugakov
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
OK, I think this is finally the issue with the tutorial race condition:
handleFirstEverAuthentication, which kick starts the tutorial logic (which eventually evals a feature flag)this.storeAuthInfoThis logic meant the feature flag call could have happened before the auth info was stored, so it would incorrectly get the feature flag for the user, and then we would cache this value.
Test plan
Verified by manually modifying the code to force
storeAuthInfoto always happen after a delayVerified that switching this logic works without the delay