Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent: make AgentWorkspaceDocuments more robust #4279

Merged
merged 2 commits into from
May 24, 2024
Merged

Agent: make AgentWorkspaceDocuments more robust #4279

merged 2 commits into from
May 24, 2024

Commits on May 23, 2024

  1. Agent: make AgentWorkspaceDocuments more robust 

    The PR #4277 was a lesson that
we have very brittle code around dealing with document synchronization.
This PR is an attempt to improve code health by

- Adding tests!
- Being more rigorous with null handling
- Making the code a bit easier to follow (hopefully)
    @olafurpg
    olafurpg committed May 23, 2024
    Configuration menu
    Copy the full SHA
    f20881b View commit details
    Browse the repository at this point in the history

  2. Make vscode.TextEditor a singleton 

    While writing more tests, I discovered a surprising behavior that I
wasn't able to reuse instances of `vscode.TextEditor`. This commit fixes
this behavior.
    @olafurpg
    olafurpg committed May 23, 2024
    Configuration menu
    Copy the full SHA
    fe020e8 View commit details
    Browse the repository at this point in the history